Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a .ci/cicd-requirements.txt file to handle CI/CD only dependencies #8716

Merged
merged 1 commit into from May 11, 2024

Conversation

misl6
Copy link
Member

@misl6 misl6 commented May 5, 2024

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

Over the past few years it happened multiple times that our CI/CD pipeline started to fail due to unpinned dependencies.

These changes are meant to move all the CI/CD specific dependencies into a separate requirements file, to avoid polluting the CI/CD scripts with multiple pip install statements.

This change also allows us to keep these dependencies versions monitored via renovatebot.

Cons:

  • Now all the requirements specified in cicd-requirements.txt get installed even if something may not be needed in a specific run. We can avoid that by using cached dependencies, however, we're talking about small-sized requirements.

@misl6 misl6 force-pushed the feat/avoid-deps-in-ci-cd-files branch from 7d807bb to be56f03 Compare May 7, 2024 17:29
@misl6 misl6 force-pushed the feat/avoid-deps-in-ci-cd-files branch from be56f03 to 838fa38 Compare May 9, 2024 19:46
@misl6 misl6 changed the title Use a cicd-requirements.txt file to handle dependencies Use a .ci/cicd-requirements.txt file to handle CI/CD only dependencies May 11, 2024
@misl6 misl6 added the Component: tests/CI Tests, CI, GitHub settings label May 11, 2024
@misl6 misl6 added this to the 3.0.0 milestone May 11, 2024
@misl6 misl6 merged commit 7b534f3 into kivy:master May 11, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: tests/CI Tests, CI, GitHub settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant