Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor mobile and Safari fixes #129

Open
wants to merge 7 commits into
base: source
Choose a base branch
from

Conversation

emiltoteb
Copy link

Fix based on Issue #128

@atodorov atodorov requested a review from asankov August 19, 2020 13:00
Copy link
Member

@asankov asankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is fixed now.

have some formatting issues that we need to fix before merging. also, drop the merge commits

@@ -110,11 +110,20 @@ code {
font-size: inherit;
border-radius: 2px;
border: 1px solid var(--trans-green);
overflow: scroll;
width: fit-content;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting is different on this line and the one above it. let's unify it

}

pre > code {
border: none;
padding: 0;
padding: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again. different formatting

@asankov asankov linked an issue Aug 19, 2020 that may be closed by this pull request
@asankov
Copy link
Member

asankov commented Aug 19, 2020

I linked the PR to the issue, so that it is automatically closes when the PR is merged. next time you can do that by adding "Fix #128" to one of the commit logs

@atodorov
Copy link
Member

@emiltoteb as promised earlier - here's the git tutorial book - free of charge but not available as HTML anymore - https://amzn.to/3aPSTo5

@asankov
Copy link
Member

asankov commented Aug 31, 2020

@emiltoteb any updates on that one? do you need any help with the comments or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background on blog posts is weird in Safari
3 participants