Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labbeling seems still not completed #3837

Closed
kelson42 opened this issue May 12, 2024 · 1 comment · Fixed by #3842
Closed

labbeling seems still not completed #3837

kelson42 opened this issue May 12, 2024 · 1 comment · Fixed by #3842
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Collaborator

Reported by Playstore:
image

ALL occurences should be fixed and the CI should check this.

@kelson42 kelson42 added the bug label May 12, 2024
@kelson42 kelson42 added this to the 3.11.0 milestone May 12, 2024
@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented May 13, 2024

@kelson42 This Multiple items have the same description content labeling issue is known and can't be fixed. Because these are inside the recyclerView where we have multiple items with the same content description. Also, views can have the same content description because they can have the same functionality. I have updated this thing on the last content labeling PR.

Screenshot from 2024-05-13 11-51-57
Screenshot from 2024-05-13 11-50-43
Screenshot from 2024-05-13 11-50-24

Apart from this, one issue is with the uk.co.deanwild.materialshowcaseview library which can't be fixed and we can ignore it since we are not using that text in our application.

Screenshot from 2024-05-13 11-52-12

ALL occurences should be fixed and the CI should check this.

Lint has the option to check the Content description, but currently we have disabled it. Okay, we will re-enable it so that CI will check these types of errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants