Detecting accessibility issues in CI. #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3842 +/- ##
============================================
+ Coverage 53.97% 54.13% +0.16%
- Complexity 1333 1340 +7
============================================
Files 292 292
Lines 11113 11117 +4
Branches 1477 1474 -3
============================================
+ Hits 5998 6018 +20
+ Misses 4133 4125 -8
+ Partials 982 974 -8 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
force-pushed
the
Fix#3837
branch
2 times, most recently
from
cef5605
to
3f7f3f5
Compare
MohitMaliFtechiz
changed the title
ContentDescription lint check.
|
@MohitMaliFtechiz Can you please rebase |
…ning for some views since we are setting the contentDescription for those views in the code.
… test the accessibility issues in our application. * This testing library only work with `ViewAction` like if we perform any click on any screen then it starts checking the accessibility issues, so we have modify our test cases according to this. * Suppress a few known accessibility issue e.g. on `LocalFileTransfer` screen we have a `skip` text which we are not using but it is giving the error for that. * Fixed the `TouchTargetIssue` in ZimHostFragment. * Added the `contentDescription` to search recyclerView.
* Added the `contentDescription` to AddNoteDialog's `close` image.
MohitMaliFtechiz
force-pushed
the
Fix#3837
branch
from
3f7f3f5
to
eb011e5
Compare
|
@kelson42 Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3837
contentDescriptionfor views and suppressed this lint warning for some views since we are setting thecontentDescriptionfor those views in the code.androidx.test.espresso:espresso-accessibilitydependency to test the accessibility issues in our application.LocalFileTransferscreen, we have askiptext which we are not using, but it is causing an error.TouchTargetIssuein ZimHostFragment.contentDescriptionto search recyclerView.contentDescriptionto AddNoteDialog'scloseimage.