-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the 'Export bookmarks' feature. #3724
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
============================================
- Coverage 53.86% 53.66% -0.21%
- Complexity 1376 1389 +13
============================================
Files 298 298
Lines 11308 11472 +164
Branches 1495 1520 +25
============================================
+ Hits 6091 6156 +65
- Misses 4226 4318 +92
- Partials 991 998 +7 ☔ View full report in Codecov by Sentry. |
@MohitMaliFtechiz Thank younfor this PR:
|
@kelson42 Yes, now we are saving and retrieving the bookmarks in libkiwix.
@kelson42 Yes, we can implement functionality in our application and guide the user to select these two files when importing the bookmarks because we need these two files to properly import the bookmarks. I was also thinking about it and i purposed this in group for your feedback. |
I really see a peovlem that library.xnl is mandatory to import bookmark.xml. Please open an issue at kiwix/libkiwix. |
@kelson42 I have opened a ticket in libkiwix kiwix/libkiwix#1069 for this. |
@MohitMaliFtechiz I believe, at this time, you don't understand how the import of bookmarks will work without having the library.xml exported/imported. Please complete the feature with only the export feature like requested first. |
* The application now exports 'bookmark.xml' file to the 'Android/media/org.kiwix...' folder. Users can copy this file to the 'Android/data/org.kiwix.../files/Bookmarks/' folder to view the exported bookmarks. * Introduced an export bookmark feature in the settings screen, allowing users to easily export all bookmarks with a simple click. A dialog prompt appears before exporting, indicating the location where the exported bookmarks will be saved and providing instructions on how to import them. * Added a test case for this change in our settings test.
* Improved the location of exporting the bookmarks. * Improved the messages that will clearly shows where and in which file bookmarks are exported.
* Refactored the test cases for this new change. * Now user can easily import the exported bookmarks by just selecting the exported `bookmark.xml` file.
…e importing of bookmarks.
Fixes #822
screen-20240604-102547.mp4
screen-20240604-171012.mp4