Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Not able to upload 512MB+ custom apps anymore. #3801

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3511

  • Introduced the splitting zim file with 500MB for custom apps. Since the bundle has a limit for a file to upload it uses the play asset delivery mode, and for new custom apps, playStore does not allow to upload the apk (with apk we can upload more than 1GB file). So to address this issue we have introduced a feature in libzim where we can load the zim files via the fd list.
  • We have modified our code to upload the files with 500MB chunks in the asset folder, and later we are accessing these files from the asset folder and creating the archive object with the help of the new libzim feature.
  • Currently CI will fail because we are using the new libzim feature in this PR. But currently new binding of java-libkiwix is not released once the new binding is released and we start using that then this error will resolve.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft April 22, 2024 13:21
@kelson42
Copy link
Collaborator

@MohitMaliFtechiz Thx for rhis PR, but its important to notice that we won't be able to put more than 3 chunks=1.5GB as asset. It does not fully fix the problem AFAIK

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Apr 22, 2024

@kelson42 We have a total combined limit of 1GB for install-time that we are currently using, above this, we still have the problem.

…e splitting zim file with 500MB for custom apps. Since the bundle has a limit for a file to upload it uses the play asset delivery mode, and for new custom apps, playStore does not allow to upload the apk (with apk we can upload more than 1GB file). So to address this issue we have introduced a feature in libzim where we can load the zim files via the fd list.

* We have modified our code to upload the files with 500MB chunks in the asset folder, and later we are accessing these files from the asset folder and creating the archive object with the help of the new libzim feature.
* It was not showing the article when fresh application is installed on device with list of fds, and after the first install it works normally(It starts loading the article). So we have placed a fix for this.
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 52.89%. Comparing base (c0588a8) to head (e192c88).

Files Patch % Lines
...org/kiwix/kiwixmobile/core/reader/ZimFileReader.kt 7.69% 12 Missing ⚠️
...iwix/kiwixmobile/core/reader/ZimReaderContainer.kt 0.00% 5 Missing ⚠️
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt 66.66% 3 Missing and 1 partial ⚠️
...rg/kiwix/kiwixmobile/core/webserver/KiwixServer.kt 0.00% 2 Missing ⚠️
...bile/nav/destination/reader/KiwixReaderFragment.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3801      +/-   ##
============================================
- Coverage     52.91%   52.89%   -0.03%     
- Complexity     1304     1308       +4     
============================================
  Files           292      292              
  Lines         11017    11027      +10     
  Branches       1464     1466       +2     
============================================
+ Hits           5830     5833       +3     
- Misses         4213     4224      +11     
+ Partials        974      970       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REGRESSION] Not able to upload 512MB+ custom apps anymore
3 participants