-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Not able to upload 512MB+ custom apps anymore. #3801
base: main
Are you sure you want to change the base?
Conversation
@MohitMaliFtechiz Thx for rhis PR, but its important to notice that we won't be able to put more than 3 chunks=1.5GB as asset. It does not fully fix the problem AFAIK |
@kelson42 We have a total combined limit of |
…e splitting zim file with 500MB for custom apps. Since the bundle has a limit for a file to upload it uses the play asset delivery mode, and for new custom apps, playStore does not allow to upload the apk (with apk we can upload more than 1GB file). So to address this issue we have introduced a feature in libzim where we can load the zim files via the fd list. * We have modified our code to upload the files with 500MB chunks in the asset folder, and later we are accessing these files from the asset folder and creating the archive object with the help of the new libzim feature.
* It was not showing the article when fresh application is installed on device with list of fds, and after the first install it works normally(It starts loading the article). So we have placed a fix for this.
db9761b
to
932ac55
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3801 +/- ##
============================================
- Coverage 52.91% 52.89% -0.03%
- Complexity 1304 1308 +4
============================================
Files 292 292
Lines 11017 11027 +10
Branches 1464 1466 +2
============================================
+ Hits 5830 5833 +3
- Misses 4213 4224 +11
+ Partials 974 970 -4 ☔ View full report in Codecov by Sentry. |
Fixes #3511
java-libkiwix
is not released once the new binding is released and we start using that then this error will resolve.