Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iso date support #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matteocrippa
Copy link

This PR add a little functionality to override currently data format used from local to ISO as optional, so turning the flag displayISODate to true makes the timestamp to be in ISO 8601 format.

@klaudiosinani klaudiosinani self-requested a review January 11, 2019 19:40
@klaudiosinani klaudiosinani added the enhancement New feature or request label Jan 11, 2019
@klaudiosinani
Copy link
Owner

klaudiosinani commented Jan 11, 2019

Nice idea! I can see how this could be useful, but I believe it would be to the benefit of the users' freedom if we could deploy the option as a standalone, much just like the current displayDate one. That way the users could pick the one that suits better to their needs.

Also, with the current overriding design, in order for the ISO date to be actually displayed both the displayISODate and displayDate must be set to true due to the guarding conditional on line 152, when both options should be independent of each other.

Please feel free to share your thoughts on this approach : )

red,
underline,
yellow
} = chalk;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded changes, like this one, should also be removed for the PR to be merged

@@ -47,6 +45,7 @@
"displayScope": true,
"displayBadge": true,
"displayDate": false,
"displayISODate": false,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

- Type: `Boolean`
- Default: `false`

Override `displayDate` format and show the current local date in ISO 8601 `YYYY-MM-DDTHH:mm:ss.TDZ` format.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display the current local date in ISO 8601 `YYYY-MM-DDTHH:mm:ss.TDZ` format.

@markusberg-spt
Copy link

I cen help out with these too if u need! Happy to conribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants