Now uses array for price_buckets #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on updates to tests for this PR. This affects #27 |
|
Love to see this PR be part of master. Very helpful. @KevinGregull did you get a chance to update tests? |
|
^bump |
|
As I said, before: Someone feel free to update those Tests. I am a bit preoccupied at the moment. But you do realize, than you can simply clone my Version of the Repository to get those changes, right? |
|
Anyone working on it? It's been years, love to have it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The System now allows for the usage of an array for the price buckets.
TODO: Update Tests.