Skip to content

followup changes from #685 #1182

followup changes from #685

followup changes from #685 #1182

Triggered via pull request April 23, 2024 15:33
Status Failure
Total duration 3m 39s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
2s
style / changes
style  /  ...  /  Auto-format and Check
17s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
3m 21s
style / Golang / Lint
style  /  ...  /  Do Not Submit
7s
style / Golang / Do Not Submit
style  /  ...  /  shell
8s
style / suggester / shell
style  /  ...  /  yaml
0s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 6 warnings
style / Golang / Lint: pkg/reconciler/ingress/ingress.go#L162
type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
style / Golang / Lint
issues found
style / suggester / shell
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/net-gateway-api/net-gateway-api. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/net-gateway-api/net-gateway-api. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/net-gateway-api/net-gateway-api. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/net-gateway-api/net-gateway-api. Supported file pattern: go.sum
style / Golang / Lint: pkg/reconciler/ingress/ingress.go#L166
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)