Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop vendor licenses #1297

Merged
merged 2 commits into from Mar 27, 2024

Conversation

dprotaso
Copy link
Contributor

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 27, 2024
@dprotaso
Copy link
Contributor Author

/assign @cardil

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.28%. Comparing base (39389b7) to head (8c4da44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1297   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files          26       26           
  Lines        2115     2115           
=======================================
  Hits         1698     1698           
  Misses        316      316           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Contributor Author

/retest

@dprotaso
Copy link
Contributor Author

oh man that last failure was explosive haha

/retest

@knative-prow knative-prow bot merged commit 57385ce into knative-extensions:main Mar 27, 2024
36 checks passed
@dprotaso dprotaso deleted the drop-vendor-licenses branch March 27, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants