Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The knative.dev/client-pkg/pkg/kn-source-pkg sub-package should be renamed and flatten #157

Open
cardil opened this issue Mar 20, 2024 · 0 comments
Open

The knative.dev/client-pkg/pkg/kn-source-pkg sub-package should be renamed and flatten #157

cardil opened this issue Mar 20, 2024 · 0 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@cardil
Copy link
Contributor

cardil commented Mar 20, 2024 •
edited

The knative.dev/client-pkg/pkg/kn-source-pkg sub-package was introduced in #74, but contains some weird stuff, that shouldn't be present in a library:

Let's clean up this as well, and leave just the actual library, just renamed to knative.dev/client-pkg/plugin/source/....

Originally posted by @cardil in #155 (comment)
@cardil cardil mentioned this issue Mar 20, 2024
Merged
@cardil cardil added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cardil