New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Clean up the kn
sub-package
#155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had removed this file because the types defined here are already present in the knative.dev/client-pkg/pkg/plugin package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 57.55% 57.57% +0.02%
==========================================
Files 113 112 -1
Lines 8382 8379 -3
==========================================
Hits 4824 4824
+ Misses 3297 3294 -3
Partials 261 261 ☔ View full report in Codecov by Sentry. |
e01393a
to
2664fae
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override codecov/project |
@cardil: Overrode contexts on behalf of cardil: codecov/project In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
kn
sub-package/kind cleanup
Fixes #152
Release Note