Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tui pkg might SIGSEGV in some CI scenarios #165

Closed
cardil opened this issue Mar 25, 2024 · 0 comments · Fixed by #164
Closed

tui pkg might SIGSEGV in some CI scenarios #165

cardil opened this issue Mar 25, 2024 · 0 comments · Fixed by #164
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented Mar 25, 2024

As seen in this build, in some CI scenarios, the tui.Spinner and tui.Progress code could panic with SIGSEGV (here an extracted SIGSEGV goroutines dump).

The tui package shouldn't panic with SIGSEGV, in case of initialization errors, due to lack of proper environment.

/kind bug
@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 25, 2024
@cardil cardil changed the title tui.Spinner and tui.Progress might SIGSEGV in some CI scenarios tui pkg might SIGSEGV in some CI scenarios Mar 25, 2024
@cardil cardil mentioned this issue Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Bubbletea initialization error handling cardil/knative-client-pkg
1 participant
@cardil