🐛 Bubbletea initialization error handling #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
do-not-merge/work-in-progress
knative-prow
bot
added
the
size/M
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
- Coverage 57.56% 57.56% -0.01%
==========================================
Files 112 113 +1
Lines 8387 8415 +28
==========================================
+ Hits 4828 4844 +16
- Misses 3298 3307 +9
- Partials 261 264 +3 ☔ View full report in Codecov by Sentry. |
|
/test unit-tests |
knative-prow
bot
added
size/L
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 25, 2024
cardil
force-pushed
the
bugfix/noterm-init-errors
branch
2 times, most recently
from
0bea26a
to
3ccca71
Compare
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 26, 2024
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 26, 2024
cardil
force-pushed
the
bugfix/noterm-init-errors
branch
3 times, most recently
from
6f43f24
to
f9af927
Compare
knative-prow
bot
removed
the
do-not-merge/work-in-progress
cardil
force-pushed
the
bugfix/noterm-init-errors
branch
from
f9af927
to
5b41668
Compare
|
/cc @dsimansk |
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 26, 2024
|
With those changes, the CI build for magetasks passes, see: https://github.com/wavesoftware/go-magetasks/actions/runs/8434810274/job/23098848334?pr=44#step:5:211 |
cardil
force-pushed
the
bugfix/noterm-init-errors
branch
from
5b41668
to
d28712a
Compare
cardil
force-pushed
the
bugfix/noterm-init-errors
branch
from
d28712a
to
8e778c5
Compare
cardil
force-pushed
the
bugfix/noterm-init-errors
branch
from
8e778c5
to
ce1a548
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 26, 2024
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 26, 2024
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 26, 2024
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 26, 2024
* Auto-install golangci-lint * Use knative/client-pkg#164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind bug
Fixes #165
Walkaround charmbracelet/bubbletea#964
Release Note