Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEGV thrown often from Spinner and Progress release terminal procedure #169

Closed
cardil opened this issue Mar 27, 2024 · 0 comments · Fixed by #170
Closed

SIGSEGV thrown often from Spinner and Progress release terminal procedure #169

cardil opened this issue Mar 27, 2024 · 0 comments · Fixed by #170
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented Mar 27, 2024

SIGSEGV is thrown quite often from:

if term.IsWriterTerminal(out) {
_ = t.ReleaseTerminal()
}

Here's goroutines dump:

$ go run github.com/cardil/repro-kn-cli-bad-license@latest
Loading... Done
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x569e90]

goroutine 6 [running]:
github.com/charmbracelet/bubbletea.(*Program).ReleaseTerminal(0xc000189450)
	/home/ksuszyns/.gvm/pkgsets/go1.21.4/global/pkg/mod/github.com/charmbracelet/bubbletea@v0.25.0/tea.go:651 +0x30
knative.dev/client-pkg/pkg/output/tui.(*BubbleSpinner).start.func1()
	/home/ksuszyns/.gvm/pkgsets/go1.21.4/global/pkg/mod/knative.dev/client-pkg@v0.0.0-20240326133606-ca64d2dc74eb/pkg/output/tui/spinner.go:94 +0xa5
created by knative.dev/client-pkg/pkg/output/tui.(*BubbleSpinner).start in goroutine 1
	/home/ksuszyns/.gvm/pkgsets/go1.21.4/global/pkg/mod/knative.dev/client-pkg@v0.0.0-20240326133606-ca64d2dc74eb/pkg/output/tui/spinner.go:87 +0x396
exit status 2

/kind bug

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 27, 2024
@cardil cardil self-assigned this Mar 27, 2024
cardil added a commit to cardil/knative-client-pkg that referenced this issue Mar 27, 2024
knative-prow bot pushed a commit that referenced this issue Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant