Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Release terminal without races, and accept stdin #170

Merged
merged 1 commit into from Mar 27, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Mar 27, 2024

Changes

  • 🐞 Release terminal without race
  • 🐞 Accept stdin without mangle

/kind bug

Fixes #168
Fixes #169

Copy link

knative-prow bot commented Mar 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Mar 27, 2024
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2024
@cardil
Copy link
Contributor Author

cardil commented Mar 27, 2024

/test unit-tests

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.56%. Comparing base (fbd71a8) to head (518467c).

Files Patch % Lines
pkg/output/tui/progress.go 0.00% 4 Missing ⚠️
pkg/output/tui/spinner.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   57.56%   57.56%           
=======================================
  Files         113      113           
  Lines        8415     8413    -2     
=======================================
- Hits         4844     4843    -1     
+ Misses       3307     3306    -1     
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil cardil marked this pull request as ready for review March 27, 2024 11:07
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
@knative-prow knative-prow bot requested review from psschwei and vyasgun March 27, 2024 11:07
@cardil
Copy link
Contributor Author

cardil commented Mar 27, 2024

/cc @dsimansk

@knative-prow knative-prow bot requested a review from dsimansk March 27, 2024 11:08
@cardil
Copy link
Contributor Author

cardil commented Mar 27, 2024

I've tested this PR on https://github.com/cardil/repro-kn-cli-bad-license with the replace:

replace knative.dev/client-pkg => github.com/cardil/knative-client-pkg v0.0.0-20240327105650-518467c4e8c5

and both issues are fixed.

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@knative-prow knative-prow bot merged commit 6984d81 into knative:main Mar 27, 2024
21 checks passed
@cardil cardil deleted the bugfix/quit-n-stdin branch March 27, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
2 participants