🐞 Fix the hang of the spinner and progress bar on stop

[cardil]

Changes

• 🐞 Fix the hang of the spinner on stop
• 🐞 Fix the hang of the progress bar on stop

/kind bug

Fixes #160
Fixes #161

Release Note

The spinner and progress bar will no longer hang on exit, which may occur on some fast rendering setups

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 57.56%. Comparing base (325b48c) to head (dd86562).

Files	Patch %	Lines
pkg/output/tui/progress.go	0.00%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   57.57%   57.56%   -0.01%     
==========================================
  Files         112      112              
  Lines        8379     8387       +8     
==========================================
+ Hits         4824     4828       +4     
- Misses       3294     3298       +4     
  Partials      261      261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cardil]

Although the 0ff3298 fix the hanging of #161, it causes the https://github.com/cardil/ghet progress bar stops rendering to early, leading to the final output could show progress bars which are not 100%, even if completed successfully:

$ go run ./cmd/ght download --destination /tmp/ghet golangci/golangci-lint
⛳️ Getting information about latest release Done
🎉 Found 2 matching assets for v1.57.1
📥 12 golangci-lint-1.57.1-linux-amd64.tar.gz  █████████████████████████████████████████░░░░  88% ⋮  20.19 MiB/s ⋮  10.55 MiB
📥 22 golangci-lint-1.57.1-checksums.txt       ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░   0% ⋮   0.00 B/s   ⋮   5.13 KiB
🔍 Verifying checksum for golangci-lint-1.57.1-linux-amd64.tar.gz Done
✅ All checksums match the downloaded assets
📦 Extracting archive: golangci-lint-1.57.1-linux-amd64.tar.gz
🎯 golangci-lint  ████████████████████████████████████████████████████████████████████████░░  97% ⋮  58.18 MiB/s ⋮  26.64 MiB

[cardil]

/cc @dsimansk

I think I got it. This version was tested against both e2e tests in magetasks, and the ghet tool (the progress bar UI is completed now).

[dsimansk]

/approve
/lgtm

I'm OK to merge per Chris' proposal even with not so polished end of progress bar for now. And further improve in next iterations.

Adding hold for other reviews, feel free to unhold per my comment above.
/hold

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cardil]

/unhold

I'll create an issue to track the removal of the explicit wait. Thx @dsimansk!

[lkingland]

/lgtm

Glad this is being merged now, and we can track that quirk separately 👍🏻