🐞 Pass hacked stdin, and don't pass stdout to bubbletea

[cardil]

Changes

• 🐞 Don't pass stdin/stdout to bubbletea
• 🐛 Don't release terminal manually

/kind bug

Fixes #173

[knative-prow]

@cardil: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.62%. Comparing base (6984d81) to head (cf59659).

Files	Patch %	Lines
pkg/output/tui/progress.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   57.56%   57.62%   +0.06%     
==========================================
  Files         113      114       +1     
  Lines        8413     8418       +5     
==========================================
+ Hits         4843     4851       +8     
+ Misses       3306     3303       -3     
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cardil]

/cc @dsimansk

[cardil]

Hmm, it fails now on GH Actions (see failure):

could not open a new TTY: open /dev/tty: no such device or address

[dsimansk]

There's a failed unit test. The same appeared in deps update PR. Strangely it wasn't failing in the previous PRs.

https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_client-pkg/174/unit-tests_client-pkg_main/1773045237422231552#1:build-log.txt%3A783-784

[cardil]

I have confirmed cf59659 working on ghet tool. Let's wait on the knative-extensions/kn-plugin-event#339 tests as well.

/hold

[cardil]

I have confirmed cf59659 working on ghet tool. Let's wait on the knative-extensions/kn-plugin-event#339 tests as well.

All have worked just fine: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_kn-plugin-event/339/integration-tests_kn-plugin-event_main/1773338506525937664#1:build-log.txt%3A695

/unhold

[dsimansk]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment