Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish missing Serving/Eventing API from unsupported version #1858

Closed
dsimansk opened this issue Aug 24, 2023 · 8 comments · May be fixed by #1868
Closed

Distinguish missing Serving/Eventing API from unsupported version #1858

dsimansk opened this issue Aug 24, 2023 · 8 comments · May be fixed by #1868
Assignees
@xiangpingjiang
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@dsimansk
Copy link
Contributor

dsimansk commented Aug 24, 2023 •
edited

Feature request

In the current implementation when kn is unable to query Knative resource, we display combined "no or newer" error on missing API or incompatible API.

Per feedback from users, that might be confusing how to approach the troubleshooting of such issue with the Knative installation.

Error: no or newer Knative Serving API found on the backend, please verify the installation or update the 'kn' client

Use case

There are 2 main scenarios to cover:

  1. There's no Knative Serving/Eventing API found on the cluster. This might be mangled installation, operators still installing, missing CRDs, controllers not up.
Error: no Knative Serving API found on the backend, please verify the installation
  1. The incompatible API version, e.g. removed v1alpha1 and therefore backend x kn mismatch.
Error: incompatible Knative Serving API found on the backend, please verify the installation or update the 'kn' client to matchin version

/cc @rhuss
@dsimansk dsimansk added the kind/feature New feature or request label Aug 24, 2023
@rhuss
Copy link
Contributor

rhuss commented Aug 25, 2023

For scenario 1, I guess or udpdate the kn client won't help :-)

@dsimansk
Copy link
Contributor Author

For scenario 1, I guess or udpdate the kn client won't help :-)

Yep, fixed the proposed errors.

@dsimansk dsimansk added the good first issue Denotes an issue ready for a new contributor. label Aug 30, 2023
@xiangpingjiang
Copy link
Contributor

xiangpingjiang commented Aug 30, 2023 •
edited

/assign @xiangpingjiang

@xiangpingjiang
Copy link
Contributor

@dsimansk Hello, David

To resolve this issue, my idea is when client gets an no or newer Knative Serving API found on the backend error, client need to get all knative crds installed in the cluster, if there is a crd same with requested resource but different version, the error becomes incompatible Knative Serving API found on the backend, otherwise the error becomes no Knative Serving API found on the backend .

Do you think is it ok ?

@rhuss
Copy link
Contributor

rhuss commented Sep 13, 2023

Sounds good, I think you can get over the /apis endpoint and I also think its good enough to check whether there is a KService resource in any version, then --> "no Knative API found", otherwise just assume that that there is a version mismatch (the only other possible error),. so no need to really check the version.

@xiangpingjiang xiangpingjiang mentioned this issue Sep 20, 2023
Open
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2023
@rhuss
Copy link
Contributor

rhuss commented Dec 14, 2023

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangpingjiang xiangpingjiang

Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Distinguish missing Serving/Eventing API from unsupported version xiangpingjiang/client
3 participants
@rhuss @dsimansk @xiangpingjiang