Distinguish missing Serving/Eventing API from unsupported version #1868

xiangpingjiang · 2023-09-20T16:44:59Z

Description

Distinguish missing Serving/Eventing API from unsupported version

Changes

Reference

Fixes #1858

Release Note

knative-prow · 2023-09-20T16:45:08Z

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow · 2023-09-20T16:45:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiangpingjiang
Once this PR has been reviewed and has the lgtm label, please assign maximilien for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow

@xiangpingjiang: 2 warnings.

In response to this:

Description

Distinguish missing Serving/Eventing API from unsupported version

Changes

Reference

Fixes #1858

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow · 2023-09-20T16:45:11Z

pkg/errors/errors.go

-	msg := fmt.Sprintf("no or newer Knative %s API found on the backend, please verify the installation or "+
-		"update the 'kn' client", firstCharToUpper(name))
-	return NewKNError(msg)
+func NewInvalidCRD(apiGroup string, resourceName string) *KNError {


Golint comments: exported function NewInvalidCRD should have comment or be unexported. More info.

knative-prow · 2023-09-20T16:45:11Z

pkg/errors/errors.go

+			"update the 'kn' client", resourceName)
+		return NewKNError(msg)
+
+	} else {


Golint indent: if block ends with a return statement, so drop this else and outdent its block. More info.

dsimansk · 2023-09-24T19:09:19Z

/ok-to-test

Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>

codecov · 2023-09-25T12:48:25Z

Codecov Report

Attention: Patch coverage is 44.00000% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 79.49%. Comparing base (f620968) to head (8bdc3fb).
Report is 40 commits behind head on main.

Files	Patch %	Lines
pkg/errors/factory.go	15.15%	27 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1868      +/-   ##
==========================================
- Coverage   79.62%   79.49%   -0.14%     
==========================================
  Files         179      179              
  Lines       13927    13969      +42     
==========================================
+ Hits        11090    11104      +14     
- Misses       2070     2097      +27     
- Partials      767      768       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiangpingjiang · 2023-09-25T13:12:22Z

/retest

dsimansk · 2023-09-26T09:31:04Z

pkg/errors/factory.go

+			if home := homedir.HomeDir(); home != "" {
+				kubeconfig = flag.String("kubeconfig", filepath.Join(home, ".kube", "config"), "(optional) absolute path to the kubeconfig file")
+			} else {
+				kubeconfig = flag.String("kubeconfig", "", "absolute path to the kubeconfig file")
+			}
+			flag.Parse()
+			// use the current context in kubeconfig
+			config, _ := clientcmd.BuildConfigFromFlags("", *kubeconfig)


I'm not a huge fan of initializing new kube client instance in such a manner. We carry-over KnParams instance that holds all the clients commonly used, in addition it covers Kube's ClientConfig parsing, reflecting --kubeconfig and --context flags. I.e. you would need to cover more edge cases here.

I'd rather inject the KnParams into the new error functions and retrieve the needed clients from it.

@dsimansk ,
I also want to reuse the KnParams, but I didn't find the right way. I will try to find how to inject the KnParams.

dsimansk · 2023-09-26T09:39:24Z

pkg/errors/errors.go

@@ -21,12 +21,23 @@ import (
 	"unicode/utf8"
 )

-func NewInvalidCRD(apiGroup string) *KNError {
+func NewInvalidCRD(apiGroup string, canFindResource string) *KNError {


How about creating a specific cause functions per message. E.g. NewInvalidCRDCauseUnknown, or define cause as a const string?

It might be easier to understand and consume whenever such new error is going to be added elsewhere etc.

github-actions · 2023-12-26T01:27:25Z

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

xiangpingjiang · 2023-12-26T12:49:42Z

/remove-lifecycle stale

github-actions · 2024-03-26T01:25:46Z

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

knative-prow bot requested review from itsmurugappan, vishal-chdhry and vyasgun September 20, 2023 16:45

knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 20, 2023

knative-prow bot reviewed Sep 20, 2023

View reviewed changes

knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2023

xiangpingjiang marked this pull request as draft September 20, 2023 16:47

knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2023

Distinguish missing Serving/Eventing API from unsupported version

e875546

Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>

xiangpingjiang force-pushed the api branch from b9b4d61 to e875546 Compare September 25, 2023 09:19

fix unit test

8bdc3fb

Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>

xiangpingjiang marked this pull request as ready for review September 25, 2023 13:04

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2023

knative-prow bot requested review from creydr and rhuss September 25, 2023 13:04

dsimansk reviewed Sep 26, 2023

View reviewed changes

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2023

knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2023

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 26, 2024

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Distinguish missing Serving/Eventing API from unsupported version #1868

Distinguish missing Serving/Eventing API from unsupported version #1868

xiangpingjiang commented Sep 20, 2023

knative-prow bot commented Sep 20, 2023

knative-prow bot commented Sep 20, 2023

knative-prow bot left a comment

knative-prow bot Sep 20, 2023

knative-prow bot Sep 20, 2023

dsimansk commented Sep 24, 2023

codecov bot commented Sep 25, 2023 •

edited

xiangpingjiang commented Sep 25, 2023

dsimansk Sep 26, 2023 •

edited

xiangpingjiang Sep 26, 2023 •

edited

dsimansk Sep 26, 2023

github-actions bot commented Dec 26, 2023

xiangpingjiang commented Dec 26, 2023

github-actions bot commented Mar 26, 2024

Distinguish missing Serving/Eventing API from unsupported version #1868

Are you sure you want to change the base?

Distinguish missing Serving/Eventing API from unsupported version #1868

Conversation

xiangpingjiang commented Sep 20, 2023

Description

Changes

Reference

knative-prow bot commented Sep 20, 2023

knative-prow bot commented Sep 20, 2023

knative-prow bot left a comment

Choose a reason for hiding this comment

Description

Changes

Reference

knative-prow bot Sep 20, 2023

Choose a reason for hiding this comment

knative-prow bot Sep 20, 2023

Choose a reason for hiding this comment

dsimansk commented Sep 24, 2023

codecov bot commented Sep 25, 2023 • edited

Codecov Report

xiangpingjiang commented Sep 25, 2023

dsimansk Sep 26, 2023 • edited

Choose a reason for hiding this comment

xiangpingjiang Sep 26, 2023 • edited

Choose a reason for hiding this comment

dsimansk Sep 26, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 26, 2023

xiangpingjiang commented Dec 26, 2023

github-actions bot commented Mar 26, 2024

codecov bot commented Sep 25, 2023 •

edited

dsimansk Sep 26, 2023 •

edited

xiangpingjiang Sep 26, 2023 •

edited