Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace steven0711dong with pierDipi in MT kafka source group #1540

Closed
wants to merge 1 commit into from

Conversation

aliok
Copy link
Member

@aliok aliok commented Mar 26, 2024

Changes

  • Knative SC is removing inactive approvers and WG leads as it is a bad project governing practice.
  • Replace steven0711dong with pierDipi in MT kafka source group.
  • That group doesn't have any folks other than @steven0711dong, so, I've added eventing lead @pierDipi there
  • I was unable to contact @steven0711dong over CNCF Slack or email.

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Mar 26, 2024

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Knative SC is removing inactive approvers and WG leads as it is a bad project governing practice.
  • Replace steven0711dong with pierDipi in MT kafka source group.
  • That group doesn't have any folks other than @steven0711dong, so, I've added eventing lead @pierDipi there
  • I was unable to contact @steven0711dong over CNCF Slack or email.

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

knative-prow bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@aliok
Copy link
Member Author

aliok commented Mar 26, 2024

cc @pierDipi

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2024
@@ -61,7 +60,7 @@ aliases:
- Leo6Leo
- cali0707
eventing-kafka-mtsource-approvers:
- steven0711dong
- pierDipi
Copy link
Member

@pierDipi pierDipi Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repository is deprecated and eventing-writers is always an owener so we don't really need anyone in this group

@aliok
Copy link
Member Author

aliok commented Mar 27, 2024

/close

I created an additional PR for removing obsolete groups: #1547

That should fix this issue.

Copy link

knative-prow bot commented Mar 27, 2024

@aliok: Closed this PR.

In response to this:

/close

I created an additional PR for removing obsolete groups: #1547

That should fix this issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants