Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose to create the new repo autoscaler-keda #1562

Merged
merged 1 commit into from
May 1, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Apr 26, 2024

Changes

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Apr 26, 2024

@skonto: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2024
@skonto
Copy link
Contributor Author

skonto commented Apr 26, 2024

cc @knative/technical-oversight-committee @dprotaso @ReToCode

@skonto
Copy link
Contributor Author

skonto commented Apr 29, 2024

cc @davidhadas @dsimansk

@davidhadas
Copy link
Contributor

/lgtm based on +1 from @dprotaso at #1527

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@skonto skonto force-pushed the create-repo-autoscaler-keda branch from 8d924dc to 99d3e46 Compare May 1, 2024 07:46
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2024
@dsimansk
Copy link
Contributor

dsimansk commented May 1, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2024
Copy link

knative-prow bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2024
@knative-prow knative-prow bot merged commit 757f71b into knative:main May 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants