Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive knative-extensions/net-certmanager repository #1564

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ReToCode
Copy link
Member

Changes

  • Archive knative-extensions/net-certmanager repository

Partially #1563

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2024
@skonto
Copy link
Contributor

skonto commented Apr 29, 2024

LGTM

@skonto
Copy link
Contributor

skonto commented Apr 29, 2024

cc @davidhadas @dsimansk @psschwei

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @dprotaso

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@dsimansk
Copy link
Contributor

/approve
/lgtm

Copy link

knative-prow bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@knative-prow knative-prow bot merged commit 1d29218 into knative:main Apr 30, 2024
5 checks passed
@dprotaso
Copy link
Member

Hey - we technically shouldn't archive net-certmanager until v1.14 and v1.13 has EOL. Which is Oct (ref)

This is in case we neet to cut a point release

@ReToCode
Copy link
Member Author

I see, just wanted to make sure no changes happen by accident. As it's already done, let's undo it when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants