Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release schedule after 1.14 #1567

Merged
merged 4 commits into from
May 3, 2024

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented May 3, 2024

  • Update release schedule after 1.14

/cc @knative/technical-oversight-committee
/cc @knative/knative-release-leads

@knative-prow knative-prow bot requested review from a team May 3, 2024 10:32
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2024
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2024
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit. But LGTM in general.
/lgtm

/hold
in case you want to address it

mechanics/RELEASE-SCHEDULE.md Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
Copy link

knative-prow bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@dsimansk
Copy link
Contributor Author

dsimansk commented May 3, 2024

@creydr thanks, I've merged your suggestion. So another lgtm will be needed.

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@creydr
Copy link
Member

creydr commented May 3, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2024
@knative-prow knative-prow bot merged commit caac287 into knative:main May 3, 2024
3 checks passed
@dsimansk dsimansk deleted the pr/release-v1.14 branch May 3, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants