Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign How to Get Involved Diagram #85

Open
mmejia02 opened this issue Nov 23, 2023 · 10 comments · May be fixed by knative/docs#5969
Open

Redesign How to Get Involved Diagram #85

mmejia02 opened this issue Nov 23, 2023 · 10 comments · May be fixed by knative/docs#5969
Assignees

Comments

@mmejia02
Copy link
Contributor

Re make the diagram for this page with correct colour scheme and style

https://knative.dev/docs/community/

@prajjwalyd
Copy link
Contributor

Hi @mmejia02!
Could you please provide some details on the preferred color scheme and style for the diagram redesign? I couldn't locate any specific information regarding the scheme or style in the repository.

@prajjwalyd
Copy link
Contributor

Quick update:

I found the instructions given here -knative/docs#5765, and I've made some adjustments to the diagram to align it with the specified color scheme...

image

This is the first draft of the updated version.
Please take a look and let me know if I'm heading in the right direction, or if anything else needs to be addressed.

@mmejia02
Copy link
Contributor Author

Hello Prajwwal! This is great, thank you so much for your work. It is worth noting that we are making a design system so I would try to make this diagram more in line with it. Here is a link to the Figma file, the first page is the design system: https://www.figma.com/file/3arTeN4tR3byPKSkrzTibp/Knative-Website?type=design&node-id=389%3A52&mode=design&t=83FbvBnMeqYt7lIe-1

So for specifics, I would include the specific Knative Website colours, the rounding of corners, and non dotted lines as default!

@mmejia02
Copy link
Contributor Author

Also, if the final could be submitted as an SVG, that would be great! If you wanted to include alt text that would be even better!

@prajjwalyd
Copy link
Contributor

prajjwalyd commented Feb 14, 2024

Hello Mariana!
Here is the final SVG output with title and desc tags for accessibility -
knative-audiences

also, what do you think about ditching the explanations from the diagram? They're already listed just below it on the community page. We could just use headings, and users can read the descriptions underneath? It might tidy up the diagram and make it look cleaner.

here is a preview of my suggestion -

image

@rohitsrma
Copy link

rohitsrma commented May 11, 2024

Hello @mmejia02, I've redesigned the diagram. Is it fine?

image

Edit: I will update the logo.

@mmejia02
Copy link
Contributor Author

Hi Rohit, this looks really really great!Can you add a link to the design file you worked on if it is on Figma? Also a minor concern is checking the colour contrast between the light blue and white lettering in the middle. In general I do think this should be officially added to the docs repo though!

@rohitsrma
Copy link

Hello @mmejia02, I've made some changes following the concern on color contrast in middle. These are the two designs i have prepared.

Frame

Frame (1)

Please let me know which one looks better.

@rohitsrma rohitsrma linked a pull request May 13, 2024 that will close this issue
@Shibbu264
Copy link

@aliok Is there any issue that I can start working on for now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants