Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign How to Get Involved Diagram #5969

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rohitsrma
Copy link
Contributor

@rohitsrma rohitsrma commented May 13, 2024

Fixes #85

Before

image

After

image

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8fe9015
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6650cc4e7451dd0008ee6438
😎 Deploy Preview https://deploy-preview-5969--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohitsrma
Once this PR has been reviewed and has the lgtm label, please assign leo6leo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from pmbanugo and ReToCode May 13, 2024 19:31
@shivamgupta2020
Copy link

shivamgupta2020 commented May 20, 2024

@rohitsrma, I think you should also change the font style.
Knative and Kubernetes fonts do not match.

@Leo6Leo
Copy link
Member

Leo6Leo commented May 26, 2024

@rohitsrma Hello Rohit, thank you for your PR. Any changes regarding the design, we should have a discussion with the design leads in the UX WG to ensure it aligns with our branding guideline. I have put this PR to the agenda for the next UX WG meeting.

It is a public meeting, so we encourage you to join us and share your insight with us! You can find the time and zoom link in the meeting note link I shared above.

@rohitsrma
Copy link
Contributor Author

Thanks a lot, @Leo6Leo! I will definitely join the meeting and look forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign How to Get Involved Diagram
3 participants