-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intro to open source with knative blog series p3 #5949
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start @Leo6Leo !
Just a couple changes needed for clarity/better rendering and then we should be good to go here!
Co-authored-by: Calum Murray <cmurray@redhat.com>
Great start and left some comments. |
@nainaz that's a great point, we should probably improve the conclusion a bit The idea is that readers would then continue to the future blog posts we are working on and make the rest of the required changes there. But, I can see how that could be unclear or leave someone unsatisfied reading the current post. |
Making it more clear would be helpful.
I probably missed the last piece of the blog. I still think adding what
would this "change" ultimately accomplish would be better
Thank you,
-N
…On Wed, 15 May 2024 at 10:13, Calum Murray ***@***.***> wrote:
Maybe that was the intention of the blog post but to me it felt that it
ended abruptly. I didn't "see" any result or output.
@nainaz <https://github.com/nainaz> that's a great point, we should
probably improve the conclusion a bit
The idea is that readers would then continue to the future blog posts we
are working on and make the rest of the required changes there. But, I can
see how that could be unclear or leave someone unsatisfied reading the
current post.
—
Reply to this email directly, view it on GitHub
<#5949 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AISZCFAB7NEDST5CMMJD4SLZCNURNAVCNFSM6AAAAABGY3RKO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGY3DMMBVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Co-authored-by: Calum Murray <cmurray@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @Leo6Leo !!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains a draft of the first post in the blog series we proposed recently to make it easier for new contributors to contribute code. The proposal can be seen here
Proposed Changes