Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented the new design navbar #5965

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShravaniAK
Copy link

current navbar :
Screenshot 2024-05-12 at 9 41 43 AM

I have changed the following,

  1. added border-radius to the search,
  2. added border-radius to the corners of the tabs items,
  3. Shifted the git source icons to the left
Screenshot 2024-05-12 at 9 43 58 AM

Copy link

knative-prow bot commented May 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShravaniAK
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from csantanapr and nainaz May 12, 2024 04:14
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 12, 2024
Copy link

netlify bot commented May 12, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e210e28
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/664042285942450008af38bc
😎 Deploy Preview https://deploy-preview-5965--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Cali0707
Copy link
Member

/cc @mmejia02 @zainabhusain227

Can the two of you check the preview and make sure it matches the designs?

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zainabhusain227
Copy link

Hey @ShravaniAK, where is the knative version number? I don't see it in the revised version. Besides that the rounded corners look good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants