Updated Design of the "Trusted By" Section #5966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/XXL
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @prajjwalyd Since the UX WG hasn't signed off on the design yet (we will in the next meeting), I'm going to put this PR on hold until we get the go-ahead from the design leads! /hold |
knative-prow
bot
added
the
do-not-merge/hold
Cali0707
approved these changes
May 31, 2024
knative-prow
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, prajjwalyd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses - knative/ux#133
Proposed Changes
It features a border around each logo, following the new Knative Design System on Figma.
Also, some of the missing logos have been added as per the instructions given in Need clarification on logos of 3 specific 'adopters' community#1561
Updated Design:
scrnli_4_26_2024_4-29-19.PM.webm
Current Design:
scrnli_3_5_2024_1-27-00.PM.webm