Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WG leads to docs approvers #5968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierDipi
Copy link
Member

Every time there is a new page added, I cannot approve PRs (example #5916), so I'm adding WG leads to the top-level directory approvers

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pierDipi
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from nainaz May 13, 2024 10:16
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@knative-prow knative-prow bot requested a review from pmbanugo May 13, 2024 10:16
Copy link

netlify bot commented May 13, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 65354fe
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6641e86d322c5c00087b64ed
😎 Deploy Preview https://deploy-preview-5968--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pierDipi
Copy link
Member Author

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team May 13, 2024 10:17
@pierDipi pierDipi changed the title Add WG leads to approvers Add WG leads to docs approvers May 13, 2024
@pierDipi
Copy link
Member Author

/assign @knative/technical-oversight-committee

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me!

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the issue is approving page changes, would it make sense to add the working group leads as owners on the config directory rather than for all of docs? Though given that there's no docs team right now, perhaps it's better to have more folks able to approve for the whole repo?

@dprotaso
Copy link
Member

If the issue is approving page changes, would it make sense to add the working group leads as owners on the config directory rather than for all of docs? Though given that there's no docs team right now, perhaps it's better to have more folks able to approve for the whole repo?

Yeah - let's subdivide the owners to the various sections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants