Re-enable PingSource TLS E2E test #7082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/work-in-progress
knative-prow
bot
added
the
size/L
knative-prow
bot
added
the
approved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7082 +/- ##
==========================================
+ Coverage 78.29% 78.31% +0.02%
==========================================
Files 250 250
Lines 13290 13320 +30
==========================================
+ Hits 10405 10432 +27
- Misses 2353 2357 +4
+ Partials 532 531 -1
☔ View full report in Codecov by Sentry. |
pierDipi
commented
Jul 7, 2023
|
1/1 worked, retesting |
|
2/2 worked, retesting |
|
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
re-enabled-ping-source-tests
branch
from
f3eee7c
to
d815e1d
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
re-enabled-ping-source-tests
branch
from
d815e1d
to
936270d
Compare
|
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
re-enabled-ping-source-tests
branch
3 times, most recently
from
287a337
to
8024abe
Compare
pierDipi
force-pushed
the
re-enabled-ping-source-tests
branch
from
8024abe
to
6486546
Compare
|
1/1 worked, retesting |
|
2/2 worked, retesting |
|
3/3 worked, retesting |
pierDipi
changed the title
|
/cc @creydr |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
removed
the
do-not-merge/work-in-progress
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Jul 25, 2023
Fixes knative#7021 This is the root cause: cloudevents/sdk-go#923 <!-- Please include the 'why' behind your changes if no issue exists --> <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Re-enable PingSource TLS E2E test - Remove hacky client injection for PingSource <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note ``` **Docs** <!-- 📖 If this change has user-visible impact, link to an issue or PR in https://github.com/knative/docs. --> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Jul 27, 2023
Fixes knative#7021 This is the root cause: cloudevents/sdk-go#923 <!-- Please include the 'why' behind your changes if no issue exists --> <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Re-enable PingSource TLS E2E test - Remove hacky client injection for PingSource <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note ``` **Docs** <!-- 📖 If this change has user-visible impact, link to an issue or PR in https://github.com/knative/docs. --> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7021
This is the root cause: cloudevents/sdk-go#923
Proposed Changes
Pre-review Checklist
Release Note
Docs