Eventing TLS: add tests for dynamically added CA trust bundles #7726
+594
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
approved
knative-prow
bot
added
size/L
pierDipi
force-pushed
the
ca-rotation-tests
branch
from
5073bbb
to
488bde0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7726 +/- ##
==========================================
+ Coverage 69.22% 69.45% +0.23%
==========================================
Files 339 344 +5
Lines 19494 16019 -3475
==========================================
- Hits 13494 11126 -2368
+ Misses 5337 4205 -1132
- Partials 663 688 +25 ☔ View full report in Codecov by Sentry. |
pierDipi
force-pushed
the
ca-rotation-tests
branch
from
488bde0
to
be92f5e
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
ca-rotation-tests
branch
from
be92f5e
to
023a7ce
Compare
|
/lgtm |
knative-prow-robot
added
the
needs-rebase
matzew
force-pushed
the
ca-rotation-tests
branch
from
023a7ce
to
754a320
Compare
knative-prow-robot
removed
the
needs-rebase
|
I rebased this PR 🙏 |
|
/cherry-pick release-1.14 |
|
@matzew: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.13 |
|
@matzew: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test reconciler-tests |
2 similar comments
|
/test reconciler-tests |
|
/test reconciler-tests |
matzew
force-pushed
the
ca-rotation-tests
branch
from
754a320
to
8109afd
Compare
|
/lgtm |
|
/hold |
knative-prow
bot
added
the
do-not-merge/hold
|
New changes are detected. LGTM label has been removed. |
|
/test reconciler-tests |
|
Fixes in #7924 |
|
/retest Tests worked locally |
|
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
force-pushed
the
ca-rotation-tests
branch
2 times, most recently
from
9b9892c
to
e4eba93
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
ca-rotation-tests
branch
from
e4eba93
to
0c5a8a1
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow
bot
added
size/XL
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
ca-rotation-tests
branch
from
a513f14
to
c592d8e
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
@pierDipi: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new tests for testing when CA trust bundles are dynamically added to the clients trust stores