Fix IMC metrics for transport encryption #7904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
Rather than reporting metrics as an aggregate for all subscriptions, we will report them for each individual subscription and based on the target scheme. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
KNATIVE-7871_Fix-imc-https-metrics
branch
from
ddd0b16
to
75f7abd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7904 +/- ##
==========================================
- Coverage 69.22% 69.20% -0.03%
==========================================
Files 339 341 +2
Lines 19494 15802 -3692
==========================================
- Hits 13494 10935 -2559
+ Misses 5337 4196 -1141
- Partials 663 671 +8 ☔ View full report in Codecov by Sentry. |
Cali0707
reviewed
May 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test reconciler-tests |
|
/test reconciler-tests |
1 similar comment
|
/test reconciler-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than reporting metrics (and scheme tag) as an aggregate for all subscriptions, we will report them for each individual subscription with the correct subscriber's scheme.