Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrossNamespace: Data Plane Changes for Broker Filter #7913

Merged
merged 4 commits into from May 17, 2024

Conversation

yijie-04
Copy link
Contributor

@yijie-04 yijie-04 commented May 10, 2024

Data plane changes are needed for the broker filter to correctly reference to brokers in the case of cross namespace referencing.

Proposed Changes

  • 🎁 Add new feature

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2024
@yijie-04
Copy link
Contributor Author

/cc @pierDipi @Cali0707

@knative-prow knative-prow bot requested review from Cali0707 and pierDipi May 10, 2024 03:54
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 68.96%. Comparing base (7e1c082) to head (49aa6bc).
Report is 52 commits behind head on main.

Current head 49aa6bc differs from pull request most recent head d164904

Please upload reports for the commit d164904 to get more accurate results.

Files Patch % Lines
pkg/broker/filter/filter_handler.go 10.00% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7913      +/-   ##
==========================================
- Coverage   69.22%   68.96%   -0.26%     
==========================================
  Files         339      341       +2     
  Lines       19494    15869    -3625     
==========================================
- Hits        13494    10944    -2550     
+ Misses       5337     4249    -1088     
- Partials      663      676      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yijie-04
Copy link
Contributor Author

@Cali0707 @pierDipi Do you think we should have a test case with BrokerRef here?

pkg/broker/filter/filter_handler.go Outdated Show resolved Hide resolved
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
Copy link

knative-prow bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, yijie-04

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@yijie-04 yijie-04 changed the title [WIP] CrossNamespace: Data Plane Changes for Broker Filter CrossNamespace: Data Plane Changes for Broker Filter May 17, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
@knative-prow knative-prow bot merged commit 15be248 into knative:main May 17, 2024
34 of 36 checks passed
@yijie-04 yijie-04 deleted the broker_data_plane branch May 17, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants