Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move new-apiserversource-filters test to experimental suite #7914

Conversation

creydr
Copy link
Member

@creydr creydr commented May 10, 2024

In #7799 new filters for the ApiServerSource and the new-apiserversource-filters feature flag were added. As they are in alpha state, they should be run in the experimental test suite.

@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label May 10, 2024
Copy link

knative-prow bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.02%. Comparing base (7e1c082) to head (0fb55c5).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7914      +/-   ##
==========================================
- Coverage   69.22%   69.02%   -0.20%     
==========================================
  Files         339      341       +2     
  Lines       19494    15853    -3641     
==========================================
- Hits        13494    10943    -2551     
+ Misses       5337     4236    -1101     
- Partials      663      674      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr force-pushed the move-TestApiServerSourceNewFiltersFeature-to-experimental branch from 2660663 to 0e00de8 Compare May 10, 2024 08:42
@pierDipi
Copy link
Member

pierDipi commented May 10, 2024

@creydr I don't think this is strictly required nor needed

@creydr
Copy link
Member Author

creydr commented May 10, 2024

@creydr I don't think this is strictly required nor needed

I agree that this is not required, but keeps it IMO clearer.

@creydr creydr force-pushed the move-TestApiServerSourceNewFiltersFeature-to-experimental branch from 476a7dc to 0fb55c5 Compare May 10, 2024 12:01
Copy link

knative-prow bot commented May 10, 2024

@creydr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing_main 0fb55c5 link true /test unit-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@creydr creydr closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants