-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move new-apiserversource-filters
test to experimental suite
#7914
Move new-apiserversource-filters
test to experimental suite
#7914
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7914 +/- ##
==========================================
- Coverage 69.22% 69.02% -0.20%
==========================================
Files 339 341 +2
Lines 19494 15853 -3641
==========================================
- Hits 13494 10943 -2551
+ Misses 5337 4236 -1101
- Partials 663 674 +11 ☔ View full report in Codecov by Sentry. |
2660663
to
0e00de8
Compare
@creydr I don't think this is strictly required nor needed |
I agree that this is not required, but keeps it IMO clearer. |
476a7dc
to
0fb55c5
Compare
@creydr: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In #7799 new filters for the ApiServerSource and the
new-apiserversource-filters
feature flag were added. As they are in alpha state, they should be run in the experimental test suite.