Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transport-encryption a Beta feature #7915

Merged
merged 1 commit into from May 15, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented May 10, 2024

it will still be disabled by default as we can't really enable it automatically
given that it depends on the cert-manager installation and a few more
setup prerequisites.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

`transport-encryption` is now a Beta feature.

Docs

knative/docs#5967

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2024
@knative-prow knative-prow bot requested review from aliok and odacremolbap May 10, 2024 13:53
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.02%. Comparing base (7e1c082) to head (444838e).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7915      +/-   ##
==========================================
- Coverage   69.22%   69.02%   -0.20%     
==========================================
  Files         339      341       +2     
  Lines       19494    15853    -3641     
==========================================
- Hits        13494    10943    -2551     
+ Misses       5337     4236    -1101     
- Partials      663      674      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi should we also update:

  1. test/config/config-features.yaml
  2. The experimental feature docs page?

@pierDipi
Copy link
Member Author

@pierDipi should we also update:

  1. test/config/config-features.yaml

No, this still needs to be tested separately

  1. The experimental feature docs page?

Yes, I'm working on the updates

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold in case you want reviews from anyone else @pierDipi

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@knative-prow knative-prow bot merged commit 3541408 into knative:main May 15, 2024
30 of 34 checks passed
@pierDipi pierDipi deleted the transport-encryption-beta branch May 15, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants