Adding uname name mapping for x86_64 in hack/install.sh

[Leo6Leo]

2024/05/10 13:56:47 Using base gcr.io/distroless/static:nonroot@sha256:e9ac71e2b8e279a8372741b7a0293afda17650d926900233ec3a7b2b7c22a246 for knative.dev/eventing/cmd/in_memory/channel_controller
Error: error processing import paths in "config/channels/in-memory-channel/deployments/dispatcher.yaml": error resolving image references: no matching platforms in base image index

In the hack/install.sh script, the uname -m gives x86_64 for the arch, but ko requires amd64

Proposed Changes

• Adding the name mapping that handles the platform argument in the KO_FLAGS variable

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Docs

[Leo6Leo]

/cc @Cali0707

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (7e1c082) to head (6108dec).
Report is 44 commits behind head on main.

❗ Current head 6108dec differs from pull request most recent head 429d73b. Consider uploading reports for the commit 429d73b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7917      +/-   ##
==========================================
+ Coverage   69.22%   69.33%   +0.11%     
==========================================
  Files         339      344       +5     
  Lines       19494    15911    -3583     
==========================================
- Hits        13494    11032    -2462     
+ Misses       5337     4197    -1140     
- Partials      663      682      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cali0707]

Hey @Leo6Leo now that I think about this a bit more, I think maybe a better approach would be to check the architecture from go env, as that would match the name of the architecture used by ko.

Maybe something like:

go env -json | jq .GOARCH -r

But, this would add a dependency on jq 🤷

@pierDipi @creydr any ideas/opinions?

[pierDipi]

this is without jq

$ go env | grep GOARCH | awk -F\' '{print $2}'
amd64

[Leo6Leo]

/cc @pierDipi @Cali0707 @creydr

[Cali0707]

/lgtm

Thanks for fixing this @Leo6Leo !

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [Cali0707]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment