[WIP] feat: add constructor for full event lineage graph #7921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
do-not-merge/work-in-progress
|
/cc @pierDipi |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Cali0707
commented
May 13, 2024
Comment on lines
+59
to
+121
| apiServerSources, err := eventingClient.SourcesV1().ApiServerSources("").List(ctx, metav1.ListOptions{}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for _, apiServerSource := range apiServerSources.Items { | ||
| if filterFunc(apiServerSource) { | ||
| g.AddSource(duckv1.Source{ | ||
| ObjectMeta: apiServerSource.ObjectMeta, | ||
| TypeMeta: apiServerSource.TypeMeta, | ||
| Spec: apiServerSource.Spec.SourceSpec, | ||
| Status: apiServerSource.Status.SourceStatus, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| containerSources, err := eventingClient.SourcesV1().ContainerSources("").List(ctx, metav1.ListOptions{}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for _, containerSource := range containerSources.Items { | ||
| if filterFunc(containerSource) { | ||
| g.AddSource(duckv1.Source{ | ||
| ObjectMeta: containerSource.ObjectMeta, | ||
| TypeMeta: containerSource.TypeMeta, | ||
| Spec: containerSource.Spec.SourceSpec, | ||
| Status: containerSource.Status.SourceStatus, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| pingSources, err := eventingClient.SourcesV1().PingSources("").List(ctx, metav1.ListOptions{}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for _, pingSource := range pingSources.Items { | ||
| if filterFunc(pingSource) { | ||
| g.AddSource(duckv1.Source{ | ||
| ObjectMeta: pingSource.ObjectMeta, | ||
| TypeMeta: pingSource.TypeMeta, | ||
| Spec: pingSource.Spec.SourceSpec, | ||
| Status: pingSource.Status.SourceStatus, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| sinkBindings, err := eventingClient.SourcesV1().SinkBindings("").List(ctx, metav1.ListOptions{}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for _, sinkBinding := range sinkBindings.Items { | ||
| if filterFunc(sinkBinding) { | ||
| g.AddSource(duckv1.Source{ | ||
| ObjectMeta: sinkBinding.ObjectMeta, | ||
| TypeMeta: sinkBinding.TypeMeta, | ||
| Spec: sinkBinding.Spec.SourceSpec, | ||
| Status: sinkBinding.Status.SourceStatus, | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
@pierDipi do you have any ideas how we could get the sources (& in the duckv1.Source struct) more easily? This process is rather manual, and would not detect any sources not in eventing core :(
|
This is WIP because I want feedback on the approach before adding unit tests |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7921 +/- ##
==========================================
- Coverage 69.22% 69.08% -0.14%
==========================================
Files 339 344 +5
Lines 19494 16069 -3425
==========================================
- Hits 13494 11101 -2393
+ Misses 5337 4286 -1051
- Partials 663 682 +19 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7694
Proposed Changes