Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃Ч Check licenses only, but not bundle them #376

Merged
merged 1 commit into from Mar 27, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Mar 27, 2024

Changes

  • 馃Ч Check licenses only, but not bundle them

/kind cleanup

Fixes knative/community#1441

Release Note

License files are no longer bundled with Knative sources, but only checked for validity

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 27, 2024
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2024
@cardil
Copy link
Contributor Author

cardil commented Mar 27, 2024

/cc @dprotaso

@knative-prow knative-prow bot requested a review from dprotaso March 27, 2024 13:14
library.sh Show resolved Hide resolved
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 47368d6 into knative:main Mar 27, 2024
6 checks passed
@cardil cardil deleted the bugfix/remove-license-bundling branch March 27, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit the need to bundle the LICENSE files in third_party folder
2 participants