Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping conversion crd update #3006

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow skipping conversion crd update #3006

wants to merge 1 commit into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Apr 3, 2024

Changes

/kind enhancement

@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 3, 2024
@dprotaso
Copy link
Member

dprotaso commented Apr 3, 2024 •
edited

Why not just delete the conversion webhook controller from your binary?

Using a context options would require re-compilation anyways

@skonto skonto mentioned this pull request Apr 5, 2024
Merged
@skonto
Copy link
Contributor Author

skonto commented Apr 5, 2024 •
edited

Why not just delete the conversion webhook controller from your binary?

We keep this aligned with the knative/operator https://github.com/knative/operator/blob/main/config/crd/bases/operator.knative.dev_knativeservings.yaml#L2470
Not sure what is coming next (if any major change) like moving from v1beta1 to v1 for example. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izabelacg izabelacg Awaiting requested review from izabelacg

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skonto @dprotaso