-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[failing] test/conformance/api/v1.TestRevisionTimeout #15089
Comments
/assign @izabelacg |
RevisionSpec.Timeout has changed meaning: #12634 |
We need to investigate if the test needs to be updated and/or if the behaviour is actually expected. See below what I observed so far. $ curl -v -H "Host: revision-timeout-writes-first-byte-before-pmzegqbs.serving-tests.example.com" "$EXTERNAL_IP?timeout=15000&initialTimeout=0"
...
> GET /?timeout=15000&initialTimeout=0 HTTP/1.1
> Host: revision-timeout-writes-first-byte-before-pmzegqbs.serving-tests.example.com
> User-Agent: curl/8.4.0
> Accept: */*
>
< HTTP/1.1 200 OK
< date: Tue, 09 Apr 2024 15:40:32 GMT
< x-envoy-upstream-service-time: 2
< vary: Accept-Encoding
< server: envoy
< transfer-encoding: chunked
<
* transfer closed with outstanding read data remaining
* Closing connection
curl: (18) transfer closed with outstanding read data remaining When curling the pod directly from within the cluster, we get: $ curl -v "10.112.5.251:8012?timeout=15000&initialTimeout=0"
* Trying 10.112.5.251:8012...
* Connected to 10.112.5.251 (10.112.5.251) port 8012
> GET /?timeout=15000&initialTimeout=0 HTTP/1.1
> Host: 10.112.5.251:8012
> User-Agent: curl/8.7.1
> Accept: */*
>
* Request completely sent off
< HTTP/1.1 200 OK
< Date: Tue, 09 Apr 2024 15:55:08 GMT
< Transfer-Encoding: chunked
<
* Connection #0 to host 10.112.5.251 left intact
Slept for 15000 milliseconds |
Note the (net-gateway-api) changes that will land in #15136 don't address this failure. |
I recall discussing this issue - something is up with the test because by the definition of the In the test we have RevisionTimeout=10s but tell the app to sleep 15s. Thus it should fail but we expect a http.StatusOK in the test which seems wrong. |
Also disabling timeouts is broken in Contour see: knative-extensions/net-gateway-api#711 |
I think this explains why the test is failing ONLY for gateway-api.
I'm wondering why the test is passing for contour and istio if this is not expected behaviour, since it seems correct behaviour for the timeouts has been established by #12634. I'm unsure if I misunderstood any of the timeouts, but here is what I've concluded so far:
|
Expected Behavior
Tests passing successfully.
Actual Behavior
Consistent failures:
Test name: test/conformance/api/v1.TestRevisionTimeout/writes_first_byte_before_timeout
Repository name: serving
Testing areas: Gateway API + Contour (periodic job)
Steps to Reproduce the Problem
See: https://testgrid.k8s.io/r/knative-own-testgrid/serving#gateway-api-contour
The text was updated successfully, but these errors were encountered: