New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix tests for revision timeouts #15181
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15181 +/- ##
==========================================
+ Coverage 84.11% 84.76% +0.65%
==========================================
Files 213 218 +5
Lines 16783 13469 -3314
==========================================
- Hits 14117 11417 -2700
+ Misses 2315 1686 -629
- Partials 351 366 +15 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: izabelacg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 668d10f.
@izabelacg: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Relates to #15089
* delete ./test/conformance/api/v1/revision_timeout_test.go since it is identical to ./test/e2e/timeout_test.go except for TestRevisionTimeout/writes_first_byte_before_timeout(learned that e2e and conformance aren't necessarily interchangeable)Release Note