Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix tests for revision timeouts #15181

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented May 2, 2024

Relates to #15089

* delete ./test/conformance/api/v1/revision_timeout_test.go since it is identical to ./test/e2e/timeout_test.go except for TestRevisionTimeout/writes_first_byte_before_timeout (learned that e2e and conformance aren't necessarily interchangeable)

  • fix expected status code for TestRevisionTimeout/writes_first_byte_before_timeout and move/rename it to TestRevisionTimeout/exceeds_total_timeout_after_first_byte
  • propose new TestRevisionTimeout/exceeds_idle_timeout that sets sleep time instead of initialSleep

Release Note


@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto May 2, 2024 22:16
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (c2d0af1) to head (cede1ec).
Report is 101 commits behind head on main.

❗ Current head cede1ec differs from pull request most recent head e42c706. Consider uploading reports for the commit e42c706 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15181      +/-   ##
==========================================
+ Coverage   84.11%   84.76%   +0.65%     
==========================================
  Files         213      218       +5     
  Lines       16783    13469    -3314     
==========================================
- Hits        14117    11417    -2700     
+ Misses       2315     1686     -629     
- Partials      351      366      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

knative-prow bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: izabelacg
Once this PR has been reviewed and has the lgtm label, please assign davidhadas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2024
Copy link

knative-prow bot commented May 21, 2024

@izabelacg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_serving_main e42c706 link true /test unit-tests
istio-latest-no-mesh_serving_main e42c706 link true /test istio-latest-no-mesh
certmanager-integration-tests_serving_main e42c706 link true /test certmanager-integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant