Add e2e test for Contour when CORS policy is enabled #15188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/L
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15188 +/- ##
==========================================
+ Coverage 84.11% 84.79% +0.67%
==========================================
Files 213 218 +5
Lines 16783 13469 -3314
==========================================
- Hits 14117 11421 -2696
+ Misses 2315 1682 -633
- Partials 351 366 +15 ☔ View full report in Codecov by Sentry. |
|
/hold for others to review |
knative-prow
bot
added
the
do-not-merge/hold
|
Thanks 🙏 |
ReToCode
reviewed
May 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: izabelacg, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
|
We should move this e2e test to net-contour - given it's specific to only that integration |
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Release Note