Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks documentation #377

Merged
merged 2 commits into from Jan 6, 2022
Merged

Add checks documentation #377

merged 2 commits into from Jan 6, 2022

Conversation

OlivierCavadenti
Copy link
Collaborator

type: "method",
method: "checkIn",
example: "column.checkIn(values)",
description: "Specify a check on column that test if the value of column is contains in a set of specified values.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains -> contained

type: "method",
method: "checkBetween",
example: "column.checkBetween(values)",
description: "Specify a check on column that test if the value of column is between a range of values.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

between -> within

language: "js",
content: `
knex.schema.createTable('product', function (table) {
table.dropChecks(['check1', 'check2']);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expand with example of setting constraint with given id first?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, that was already included.
approved!

@kibertoad
Copy link
Collaborator

@OlivierCavadenti minor text fixes still left

@OlivierCavadenti OlivierCavadenti merged commit 06b42a1 into knex:gh-pages Jan 6, 2022
@OlivierCavadenti OlivierCavadenti deleted the check-doc branch January 6, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants