Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for better-sqlite3 #146

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

faulpeltz
Copy link
Contributor

This adds support for the better3-sqlite driver which has been supported by Knex for while now

  • minimal changes to a query in sqlite dialect (this seems related to how better-sqlite3 handles parameter binding)
  • runs the same tests for sqlite3 and better-sqlite3 driver

@titanism
Copy link

Related #147

@titanism
Copy link

@rijkvanzanten @aidenfoxx can you please merge and release this to npm? thank you 🙏

@rijkvanzanten
Copy link
Collaborator

Sure thing! FWIW I'm not sure if this library is maintained still. I've been out of this project for a while, and am not a member of the knex org (so can't archive this repo). The SQL queries don't really change necessarily, but just be aware that it might be worth running this off of a fork 👍🏻

@titanism
Copy link

@rijkvanzanten thank you - just ping us back once released to npm. also - you might want to regenerate the lockfile from scratch because it looks like @faulpeltz has updated it in the commit (which should be done by maintainer)

@titanism
Copy link

we use np for releases fyi it's great and simple https://github.com/sindresorhus/np

@rijkvanzanten
Copy link
Collaborator

we use np for releases fyi it's great and simple https://github.com/sindresorhus/np

I usually rely on a GH action for releases 🙂

@rijkvanzanten rijkvanzanten merged commit 67eaa33 into knex:master Oct 25, 2023
1 check failed
@rijkvanzanten
Copy link
Collaborator

Should be up as 3.1.0 👍🏻

@titanism
Copy link

you're the best @rijkvanzanten 🙏 thank you

we're looking at using this for our project https://forwardemail.net - much appreciated work!

@rijkvanzanten
Copy link
Collaborator

Cool!! It's what's currently powering Directus although I migrated over to an in-house @directus/schema fork instead due to our desired move to ESM which wasn't shared by this org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants