Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify reinsert logic when altering a table in SQLite #4272

Merged
merged 1 commit into from Feb 3, 2021
Merged

Simplify reinsert logic when altering a table in SQLite #4272

merged 1 commit into from Feb 3, 2021

Conversation

nickrum
Copy link
Contributor

@nickrum nickrum commented Feb 3, 2021

This is the procedure recommended by the SQLite Docs. It saves a few SQL statements, most importantly copying the data twice.

Unfortunately, SQLite's RENAME TABLE adds double quotes around the table name, so I had to alter some of the tests.

@nickrum nickrum changed the title Simplify reinsert logic Simplify reinsert logic when altering a table in SQLite Feb 3, 2021
@kibertoad
Copy link
Collaborator

A bunch of tests are failing.

@nickrum
Copy link
Contributor Author

nickrum commented Feb 3, 2021

Not sure, why some of the mysql tests are failing.

@kibertoad
Copy link
Collaborator

@nickrum I think this is GitHub going haywire internally, I'm observing the same on other PRs now. Probably will resolve itself in a couple of hours.

@kibertoad
Copy link
Collaborator

@nickrum It's green now.

@kibertoad kibertoad merged commit edf994d into knex:master Feb 3, 2021
@nickrum nickrum deleted the sqlite-reinsert-improvement branch February 3, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickrum @kibertoad