Creating .fromRaw API & its tests #4429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elhigu What do you think? |
elhigu
reviewed
Jul 21, 2021
| @@ -203,6 +203,17 @@ class Builder extends EventEmitter { | |||
| return this; | |||
| } | |||
|
|
|||
| fromRaw(sql, bindings) { | |||
| //Verify if is rawInstance | |||
There was a problem hiding this comment.
why this is not implemented just
const raw = sql.isRawInstance ? sql : this.client.raw(sql, bindings);
return this.from(raw)
Merged
|
Superseded by #4781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attemp to solve #1767 . I'm new to the lib and this is my first PR. Any changes or things to add let me know 馃槂.