Implementing .whereLike and .whereILike api #4457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Could you also please add some integration tests that actually retrieve some data? see |
added 2 commits
April 28, 2021 13:09
kibertoad
reviewed
Apr 28, 2021
| @@ -479,6 +479,22 @@ class QueryCompiler_MSSQL extends QueryCompiler { | |||
| } | |||
| return offset; | |||
| } | |||
|
|
|||
| whereLike(statement) { | |||
| return `[${ | |||
There was a problem hiding this comment.
Shouldn't this need some escaping for variables? I think for columns we typically use formatter.columnize, and for a single value client.parameter. See C:\sources\node\knex\lib\query\querycompiler.js for an example.
kibertoad
reviewed
Apr 28, 2021
| @@ -218,6 +218,18 @@ class QueryCompiler_PG extends QueryCompiler { | |||
| distinctOn(value) { | |||
| return 'distinct on (' + this.formatter.columnize(value) + ') '; | |||
| } | |||
|
|
|||
| whereLike(statement) { | |||
There was a problem hiding this comment.
Do we still need client-specific implementations of this functions if we use standard knex escaping mechanism? I assume there are no other differences?
|
I can finish this PR. Can you add me to collaborators on this branch @LucasHFS ? |
|
Superseded by #4779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to solve #2265 .