Zero precision in timestamp/datetime #4784 #4786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
OlivierCavadenti
commented
Oct 30, 2021
OlivierCavadenti
commented
- Fixes Can's set zero precision to timestamp #4784
- Remove duplicate (actually timestamp == datetime implementation in PG) and so correct datetime precision = 0 too.
kibertoad
reviewed
Oct 30, 2021
| @@ -72,22 +72,13 @@ class ColumnCompiler_PG extends ColumnCompiler { | |||
| useTz = !withoutTz; | |||
| } | |||
| useTz = typeof useTz === 'boolean' ? useTz : true; | |||
| precision = precision ? '(' + precision + ')' : ''; | |||
| precision = precision !== undefined ? '(' + precision + ')' : ''; | |||
There was a problem hiding this comment.
can we also check for null here?
kibertoad
reviewed
Oct 30, 2021
| precision = precision ? '(' + precision + ')' : ''; | ||
|
|
||
| return `${useTz ? 'timestamptz' : 'timestamp'}${precision}`; | ||
| return this.datetime(withoutTz, precision); |
kibertoad
approved these changes
Oct 30, 2021
|
@OlivierCavadenti If you think we need to release it as a hotfix, we should also backport it to 0.95 branch. |
yes we can. do you have any conventation (naming, ...) to make the backport ? |
|
@OlivierCavadenti I don't think we have one. Also feel free to merge approved PRs at your convenience! |
OlivierCavadenti
added a commit
to OlivierCavadenti/knex
that referenced
this pull request
Oct 30, 2021
OlivierCavadenti
added a commit
to AbeonaPascha/knex
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.