Mysql2 validate connection fix #4794 #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
OlivierCavadenti
commented
Nov 8, 2021
OlivierCavadenti
commented
- Fix mysql2 validate connection.
- Closes MYSQL2 Dialect - Connection not disposed after a connection error during query execution #4794 (comment)
kibertoad
approved these changes
Nov 8, 2021
|
Could you also backport this to 0.95? |
OlivierCavadenti
added a commit
that referenced
this pull request
Nov 8, 2021
Yeah put I push without a PR (I push on the upstream instead of fork unfortunaly): |
|
sure, np! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.